Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily Disabling Flaky Integration Tests in Plugin Example Apps #8109

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Temporarily Disabling Flaky Integration Tests in Plugin Example Apps #8109

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
61073b5
skipped flaky integration tests
jesswrd Nov 15, 2024
11303a9
added TODOs and formatted files
jesswrd Nov 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/camera/camera/example/integration_test/camera_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ void main() {
await controller.dispose();
}
}
});
}, skip: true);

// This tests that the capture is no bigger than the preset, since we have
// automatic code to fall back to smaller sizes when we need to. Returns
Expand Down
14 changes: 7 additions & 7 deletions packages/camera/camera_android/example/integration_test/camera_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ void main() {
await controller.dispose();
}
}
});
}, skip: true);

// This tests that the capture is no bigger than the preset, since we have
// automatic code to fall back to smaller sizes when we need to. Returns
Expand Down Expand Up @@ -197,7 +197,7 @@ void main() {
await videoController.dispose();

expect(duration, lessThan(recordingTime - timePaused));
});
}, skip: true);

testWidgets('Set description while recording', (WidgetTester tester) async {
final List<CameraDescription> cameras =
Expand Down Expand Up @@ -234,7 +234,7 @@ void main() {
// cameras switched
expect(controller.description, cameras[1]);
}
});
}, skip: true);

testWidgets('Set description', (WidgetTester tester) async {
final List<CameraDescription> cameras =
Expand All @@ -249,7 +249,7 @@ void main() {
await controller.setDescription(cameras[1]);

expect(controller.description, cameras[1]);
});
}, skip: true);

testWidgets(
'image streaming',
Expand Down Expand Up @@ -281,7 +281,7 @@ void main() {

await controller.stopImageStream();
await controller.dispose();
},
}, skip: true
);

testWidgets(
Expand Down Expand Up @@ -320,7 +320,7 @@ void main() {
await controller.dispose();

expect(controller.value.isStreamingImages, false);
},
}, skip: true
);

group('Camera settings', () {
Expand Down Expand Up @@ -457,5 +457,5 @@ void main() {
expect(lengths[n], greaterThan(0));
}
});
});
}, skip: true);
}
2 changes: 1 addition & 1 deletion packages/camera/camera_android_camerax/example/integration_test/integration_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ void main() {
await controller.dispose();
}
}
});
}, skip: true);

testWidgets('Preview takes expected resolution from preset',
(WidgetTester tester) async {
Expand Down