Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix popup menu offset when using useRootNavigator in PopupMenu #144670

Merged
merged 4 commits into from
May 24, 2024
Merged

fix popup menu offset when using useRootNavigator in PopupMenu #144670

merged 4 commits into from
May 24, 2024

Conversation

joodo
Copy link
Contributor

@joodo joodo commented Mar 6, 2024

fix issue #144669

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@google-cla Google CLA
Copy link

google-cla bot commented Mar 6, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Mar 6, 2024
QuncCccccc
QuncCccccc approved these changes May 21, 2024
View reviewed changes
Copy link
Contributor

@QuncCccccc QuncCccccc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the contribution:)

QuncCccccc
QuncCccccc reviewed May 21, 2024
View reviewed changes
packages/flutter/test/material/popup_menu_test.dart Outdated
@@ -926,6 +926,52 @@ void main() {
expect(tester.getTopLeft(popupFinder), buttonTopLeft);
});

testWidgets(
'PopupMenu positioning inside nested Navigator when useRootNavigator',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: don't need to start a new line here:)

justinmc
justinmc approved these changes May 22, 2024
View reviewed changes
Copy link
Contributor

@justinmc justinmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Thanks for fixing this!

@QuncCccccc
Copy link
Contributor

@joodo Could you help with the conflicts? Then we are good to go!

@QuncCccccc QuncCccccc added the autosubmit Merge PR when tree becomes green via auto submit App label May 24, 2024
@auto-submit auto-submit bot merged commit 734d243 into flutter:master May 24, 2024
72 checks passed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 25, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 25, 2024
@engine-flutter-autoroll
734d243bc fix popup menu offset when using useRootNavigator in `Pop…
8b2ca78 
…upMenu` (flutter/flutter#144670)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request May 25, 2024
@engine-flutter-autoroll
Roll Flutter from 8dd08314d2e4 to cb26a01a40e9 (12 revisions) (#6794)
d52b992 
flutter/flutter@8dd0831...cb26a01

2024-05-25 [email protected] Roll Flutter Engine from e0207131ea13 to 1d154ff93a87 (1 revision) (flutter/flutter#149070)
2024-05-25 [email protected] Roll Flutter Engine from f693fdd840e8 to e0207131ea13 (7 revisions) (flutter/flutter#149068)
2024-05-25 [email protected] Roll Flutter Engine from b5e98f9b8d0f to f693fdd840e8 (4 revisions) (flutter/flutter#149057)
2024-05-24 [email protected] fix popup menu offset when using `useRootNavigator` in `PopupMenu` (flutter/flutter#144670)
2024-05-24 [email protected] [GAR][a11y] Update assessment app to unblock tester from testing dark mode (flutter/flutter#149055)
2024-05-24 [email protected] [a11y] Slider should respect bold text setting (flutter/flutter#149053)
2024-05-24 [email protected] Add tests for editable_text.on_changed.0.dart API example. (flutter/flutter#148874)
2024-05-24 [email protected] Roll Flutter Engine from 979214444aca to b5e98f9b8d0f (1 revision) (flutter/flutter#149051)
2024-05-24 [email protected] Add test for text_editing_controller.0.dart API example. (flutter/flutter#148872)
2024-05-24 [email protected] Roll Flutter Engine from 4ab442475223 to 979214444aca (3 revisions) (flutter/flutter#149045)
2024-05-24 [email protected] Fix TwoDimensionalViewport's keep alive child not always removed (when no longer should be kept alive) (flutter/flutter#148298)
2024-05-24 [email protected] Roll Packages from 1008d9e to 7b423f5 (2 revisions) (flutter/flutter#149043)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@Piinks Piinks mentioned this pull request May 31, 2024
Open
victorsanni pushed a commit to victorsanni/flutter that referenced this pull request May 31, 2024
@joodo @victorsanni
fix popup menu offset when using useRootNavigator in PopupMenu (f…
9a87b2d 
…lutter#144670)

fix issue flutter#144669
arc-yong pushed a commit to Arctuition/packages-arc that referenced this pull request Jun 14, 2024
@engine-flutter-autoroll @arc-yong
Roll Flutter from 8dd08314d2e4 to cb26a01a40e9 (12 revisions) (flutte…
3657e6b 
…r#6794)

flutter/flutter@8dd0831...cb26a01

2024-05-25 [email protected] Roll Flutter Engine from e0207131ea13 to 1d154ff93a87 (1 revision) (flutter/flutter#149070)
2024-05-25 [email protected] Roll Flutter Engine from f693fdd840e8 to e0207131ea13 (7 revisions) (flutter/flutter#149068)
2024-05-25 [email protected] Roll Flutter Engine from b5e98f9b8d0f to f693fdd840e8 (4 revisions) (flutter/flutter#149057)
2024-05-24 [email protected] fix popup menu offset when using `useRootNavigator` in `PopupMenu` (flutter/flutter#144670)
2024-05-24 [email protected] [GAR][a11y] Update assessment app to unblock tester from testing dark mode (flutter/flutter#149055)
2024-05-24 [email protected] [a11y] Slider should respect bold text setting (flutter/flutter#149053)
2024-05-24 [email protected] Add tests for editable_text.on_changed.0.dart API example. (flutter/flutter#148874)
2024-05-24 [email protected] Roll Flutter Engine from 979214444aca to b5e98f9b8d0f (1 revision) (flutter/flutter#149051)
2024-05-24 [email protected] Add test for text_editing_controller.0.dart API example. (flutter/flutter#148872)
2024-05-24 [email protected] Roll Flutter Engine from 4ab442475223 to 979214444aca (3 revisions) (flutter/flutter#149045)
2024-05-24 [email protected] Fix TwoDimensionalViewport's keep alive child not always removed (when no longer should be kept alive) (flutter/flutter#148298)
2024-05-24 [email protected] Roll Packages from 1008d9e to 7b423f5 (2 revisions) (flutter/flutter#149043)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuncCccccc QuncCccccc QuncCccccc approved these changes

@justinmc justinmc justinmc approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@joodo @QuncCccccc @justinmc