fix(android): wrap context with AppCompat theme for Google Pay button #2321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes flutter-stripe#1907 The Google Pay PayButton uses AppCompatTextView internally, which requires a Theme.AppCompat theme. When the host app uses a non-AppCompat theme, this causes errors like: "View class android.support.v7.widget.AppCompatTextView is an AppCompat widget that can only be used with a Theme.AppCompat theme" Changed ReactContext to extend ContextThemeWrapper with an explicit AppCompat theme instead of plain ContextWrapper, ensuring all platform views have access to AppCompat theme attributes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The Google Pay
PayButtonusesAppCompatTextViewinternally, which requires aTheme.AppCompattheme. When the host app uses a non-AppCompat theme (e.g.,Theme.MaterialComponentsor other themes), this causes errors:Root cause:
ReactContextextendedContextWrapper(currentActivity)directly, which doesn't guarantee AppCompat theme attributes are available.Fix: Changed
ReactContextto extendContextThemeWrapperwith an explicitTheme_AppCompat_Light_NoActionBartheme, ensuring all platform views have access to AppCompat theme attributes regardless of the host app's theme.Test plan