fix(issue-2282): make params optional in confirmPayment method to sol… #2287
Conversation
| return | ||
| } | ||
|
|
||
| let params = arguments["params"] as? NSDictionary |
There was a problem hiding this comment.
I think if you use NSNull() as fallback then you can revert the NSDictionary? => NSDictionary change in the other file and make it "survive" the next sync
There was a problem hiding this comment.
no way that confirmPayement would accept an NSNull as param, or not?
I get:
There was a problem hiding this comment.
@jonasbark , I didn't think that if this PR should be applied, we would be protected from regression, because the library won't compile if we don't make
nullable when a new SDK is 'imported'. We need just a comment in our caller method.
There was a problem hiding this comment.
I think Stripe wants us to use the confirmplatformpayment method in this case so I prefer we use that one instead of fixing something here
There was a problem hiding this comment.
@pgiacomo69 I think this dirty trick will work in stripeplugin.swift
let params = (arguments["params"] as? NSDictionary) ?? (NSNull() as Any as! NSDictionary)There was a problem hiding this comment.
Thank you @remonh87! I (or my colleague Luan, that commented the issue) wil check it tomorrow!
…irmPayment method
4 participants
Solve the issue #2282.
@remonh87, @jonasbark I'm aware that we shouldn't change code from StripeSDK, because it belongs to React Native SDK that we import in this project, but how should are we supposed to solve it?
Should I PR on Stripe repository for a rollback of
flutter_stripe/packages/stripe_ios/ios/stripe_ios/Sources/stripe_ios/Stripe Sdk/StripeSdkImpl.swift
Line 822 in 903f367