-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix sparql query-credential APIs #843
Conversation
# Conflicts: # src/clj/fluree/db/query/api.cljc
Most of these changes are already covered in #800 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🌙
@JaceRockman Do you want me to hold off merging this and work on the corresponding changes in your branch? I originally tackled this based on your ask in Slack... and albeit it turned from a single-commit fix that took about an hour to to something that ended up being much larger to address the good feedback and some other related changes that were not fix-specific. |
Yeah, I see some of your comments on my PR, I can fix those there if we just want to make all of these changes as one PR. |
I'm inclined to merge this one, and then rebase #800 on this work. This one is ready to go and is a subset of that one, so that seems like the smoothest path. |
Closed in favor of #800 |
This fixes SPARQL support for credential-query and credential-query-connection.