Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sparql query-credential APIs #843

Closed
wants to merge 9 commits into from
Closed

Conversation

bplatz
Copy link
Contributor

@bplatz bplatz commented Jul 18, 2024

This fixes SPARQL support for credential-query and credential-query-connection.

@bplatz bplatz requested a review from a team July 18, 2024 10:56
@bplatz bplatz marked this pull request as draft July 19, 2024 00:07
@bplatz bplatz marked this pull request as ready for review July 19, 2024 10:33
@JaceRockman
Copy link
Contributor

Most of these changes are already covered in #800

Copy link
Contributor

@dpetran dpetran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌙

@bplatz
Copy link
Contributor Author

bplatz commented Jul 19, 2024

Most of these changes are already covered in #800

@JaceRockman Do you want me to hold off merging this and work on the corresponding changes in your branch?

I originally tackled this based on your ask in Slack... and albeit it turned from a single-commit fix that took about an hour to to something that ended up being much larger to address the good feedback and some other related changes that were not fix-specific.

@JaceRockman
Copy link
Contributor

Most of these changes are already covered in #800

@JaceRockman Do you want me to hold off merging this and work on the corresponding changes in your branch?

I originally tackled this based on your ask in Slack... and albeit it turned from a single-commit fix that took about an hour to to something that ended up being much larger to address the good feedback and some other related changes that were not fix-specific.

Yeah, I see some of your comments on my PR, I can fix those there if we just want to make all of these changes as one PR.

@dpetran
Copy link
Contributor

dpetran commented Jul 19, 2024

I'm inclined to merge this one, and then rebase #800 on this work. This one is ready to go and is a subset of that one, so that seems like the smoothest path.

@bplatz
Copy link
Contributor Author

bplatz commented Jul 22, 2024

Closed in favor of #800

@bplatz bplatz closed this Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants