Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add finalizer #93

Merged
merged 2 commits into from
Jan 19, 2025
Merged

feat: add finalizer #93

merged 2 commits into from
Jan 19, 2025

Conversation

godu
Copy link
Contributor

@godu godu commented Jan 10, 2025

Destroy client after layer lifecycle to release idle connections.

Copy link

changeset-bot bot commented Jan 10, 2025

🦋 Changeset detected

Latest commit: a1ef0c8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 36 packages
Name Type
@effect-aws/client-api-gateway-management-api Minor
@effect-aws/client-cognito-identity-provider Minor
@effect-aws/client-opensearch-serverless Minor
@effect-aws/client-cloudwatch-events Minor
@effect-aws/client-cloudwatch-logs Minor
@effect-aws/client-secrets-manager Minor
@effect-aws/client-organizations Minor
@effect-aws/client-auto-scaling Minor
@effect-aws/client-cloudsearch Minor
@effect-aws/client-elasticache Minor
@effect-aws/client-eventbridge Minor
@effect-aws/client-cloudtrail Minor
@effect-aws/client-cloudwatch Minor
@effect-aws/client-codedeploy Minor
@effect-aws/client-opensearch Minor
@effect-aws/client-scheduler Minor
@effect-aws/client-dynamodb Minor
@effect-aws/client-textract Minor
@effect-aws/client-account Minor
@effect-aws/client-bedrock Minor
@effect-aws/client-kinesis Minor
@effect-aws/client-lambda Minor
@effect-aws/client-ec2 Minor
@effect-aws/client-ecr Minor
@effect-aws/client-ecs Minor
@effect-aws/client-iam Minor
@effect-aws/client-kms Minor
@effect-aws/client-rds Minor
@effect-aws/client-sfn Minor
@effect-aws/client-sns Minor
@effect-aws/client-sqs Minor
@effect-aws/client-ssm Minor
@effect-aws/client-sts Minor
@effect-aws/client-mq Minor
@effect-aws/client-s3 Minor
@effect-aws/lib-dynamodb Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@godu
Copy link
Contributor Author

godu commented Jan 10, 2025

I'm not sure what the major change is.

Scope is added as a requirement, which seems annoying enough to make it a non-trivial update.

@floydspace
Copy link
Owner

thanks @godu I will carefully review it and diside if it should be major.
I would not like to do major update yet though

Copy link
Owner

@floydspace floydspace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @godu , I like this change, but please consider my comments

packages/client-account/src/AccountClientInstance.ts Outdated Show resolved Hide resolved
packages/client-account/test/Account.test.ts Outdated Show resolved Hide resolved
scripts/codegen-client.ts Outdated Show resolved Hide resolved
@floydspace floydspace merged commit a96fbd8 into floydspace:main Jan 19, 2025
2 checks passed
@github-actions github-actions bot mentioned this pull request Jan 19, 2025
@godu godu deleted the feat/finalizer branch January 20, 2025 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants