Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Use custom flow-typed repository as source #3750

Closed
wants to merge 2 commits into from
Closed

[WIP] Use custom flow-typed repository as source #3750

wants to merge 2 commits into from

Conversation

moroine
Copy link
Contributor

@moroine moroine commented Feb 23, 2020

  • Type of contribution: addition

Other notes:

This PR adds the possibility to use a custom flow-typed repository as source in order to be able to fetch definitions from private repository.

@moroine
Copy link
Contributor Author

moroine commented Feb 23, 2020

Draft PR due to missing tests

@gantoine gantoine self-assigned this Feb 25, 2020
@gantoine gantoine added the cli Related to CLI tool label Mar 22, 2020
@Brianzchen
Copy link
Member

Hi @moroine how are plans to continue this PR? The idea is pretty cool and would provide an easy way to integrate flow into a large org where we may not have control over all repo's to add flow defs. I was thinking to build a custom installer solution for myself but this would solve that problem for others.

@moroine
Copy link
Contributor Author

moroine commented Apr 8, 2021

@Brianzchen I didn't get time to continue on this PR 😢

Currently, I'm managing this using this kind of flowconfig

[ignore]
<PROJECT_ROOT>/node_modules/.*
!<PROJECT_ROOT>/node_modules/@nugit/.*

[declarations]
<PROJECT_ROOT>/node_modules/@nugit/.*

[options]
module.name_mapper='^@nugit/logger-service' -> '<PROJECT_ROOT>/node_modules/@nugit/logger-service/src/index.js'
module.name_mapper='^@nugit/env-service' -> '<PROJECT_ROOT>/node_modules/@nugit/env-service/src/index.js'

@Brianzchen
Copy link
Member

Hi @moroine this change actually looks like something that would change where flow-typed pulls it's flow-typed cache from, but that would mean this new source of truth would need to maintain every library. What if I want to just store private libraries and want to use it as a proxy like the issue I raised here #4142. Would that be more valuable?

And not sure if you plan to continue no this PR some day, but it looks like a really great change and lot of effort already put in!

@moroine
Copy link
Contributor Author

moroine commented Dec 3, 2021

Yup, unfortunately, I didn't manage to finish this PR. I doesn't have the time currently 😬 .

I think the idea would be to be able to configure in a dotfile config which definition is pulled from which repo

@moroine moroine closed this by deleting the head repository Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli Related to CLI tool
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants