Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MFC key dictionary #3987

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

jblanked
Copy link

@jblanked jblanked commented Nov 3, 2024

What's new

Verification

  • [ Describe how to verify changes ]

Checklist (For Reviewer)

  • PR has description of feature/bug or link to Confluence/Jira task
  • Description contains actions to verify feature/bugfix
  • I've built this code, uploaded it to the device and verified feature/bugfix

@equipter
Copy link
Contributor

equipter commented Nov 4, 2024

a lot of these are not validated as static in any way. "some random card" being the origin for one of these is scary enough.

just because they're from MCT doesn't make them reliable enough to blindly merge imo.

@noproto
Copy link
Contributor

noproto commented Nov 4, 2024

We need verified static keys, these are not and will only offset the improvements we just made in MFC. PM3 has many verified static keys and it's a good reference dictionary to use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants