Add an option to disable ImPlot #1350
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't know if we want to maintain a non-implot version of every graph forever |
Right now it's only one (or two) graphs (so the situation is relatively manageable) 🐸 |
TheComputerGuy96
force-pushed
the
implot-optional
branch
from
3bded89 to
8917089
Compare
The ImPlot dependency causes significant library size and build time increases (at least for debug builds) so add an option to disable it This change also adds more mentions of the ImPlot dependency in the documentation (and adds a warning about missing ImPlot)
TheComputerGuy96
force-pushed
the
implot-optional
branch
from
8917089 to
b179742
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ImPlot dependency causes significant library size and build time increases (at least for debug builds) so add an option to disable it
This change also adds more mentions of the ImPlot dependency in the documentation (and adds a warning about missing ImPlot)