-
Notifications
You must be signed in to change notification settings - Fork 54
feat[FieldData]: export to ZBF #2397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, looks great! Only some minor comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @bzhangflex , this looks great! Will be super useful and a highly requested feature!
I had a few minor comments. I'm not familiar with zemax configuration so take what I say with a bit of a grain of salt.
Since this is a bit experimental and largely untested, there might be cases that it will not work properly. Should we add a warning when it's called? Something like "This is an experimental feature. If you run into any issues, contact us at flexcompute.com/tidy3d/technical-support/" |
Pushed quite a few changes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking like it's almost there! mostly minor comments
Thanks @tylerflex!, let me know how it looks now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, thanks @bzhangflex !
eb23a1f
to
be046e0
Compare
to_zbf()
method toFieldData
for exporting E fields to a ZBF file.from_zbf()
method toFieldDataset
for importing E fields from a ZBF file.ZBFData
class for reading ZBF filesCloses #2321