-
Notifications
You must be signed in to change notification settings - Fork 54
Add zbf file export in 2.9 #2321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Sounds great, Tom, but I do not have the bandwidth to work on it. I'm more than happy to help whoever does the integration understand the code, though. It is super straightforward. |
I added @yaugenst-flex to re-assign as needed. |
This is what I created when the request first came up: https://gist.github.com/lucas-flexcompute/ac8f8abc376f51222aad36beacb223ac |
Seems like the hard work has already been done by @lucas-flexcompute, is the task just to integrate his function into the frontend? What would be a good way to interface with this function? I'm thinking it could be added to monitor objects so a user can call simdata['mon_name'].to_zbf() |
Hi @bhnzhang , yes the task is just to integrate this into the frontend. Of course, if you spot anything that might need fixing, feel free to go for it too, but in principle this is just writing a wrapper for what Lucas already implemented. I think adding a method to A few things to think about while implementing
|
After discussion with tyler, momchil and all we think it might be worth it to officially add the zbf file export to our stable version in 2.9, even though we can't fully test it. At the same time we can add a warning like "this is an experimental feature, if you encounter any issues with the exported file, please contact us".
The text was updated successfully, but these errors were encountered: