Added group delay calculation notebook #300
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomflexcompute
requested review from
alec-flexcompute,
FilipeFcp and
yuanshen-flexcompute
alec-flexcompute
approved these changes
Jun 4, 2025
There was a problem hiding this comment.
Impressive result @tomflexcompute ! Content-wise, it's great! There's just a couple spelling errors:
Above cell 2, "waveguide" is misspelled
Above cell 9, "derivative" is misspelled
Other than that, this is a very straightforward presentation of some very nice results - great job as always
yuanshen-flexcompute
approved these changes
Jun 4, 2025
There was a problem hiding this comment.
- Small typo above cell 2: "group delay on the waveguide bend"
- Typo above cell 6: "ModeSource"
- Typo above cell 9: both occurrences of "derivative"
- Around cell 5 when gdstk is used, perhaps include a link to this article or this page in case users are unfamiliar with it?
Very clear and concise article overall.
|
Spell check passed successfully for 1 notebook(s). |
FilipeFcp
approved these changes
Jun 5, 2025
There was a problem hiding this comment.
Nice and clear @tomflexcompute!
There is one remaining typo on cell [5]: create a waevguide -> create a waveguide.
tomflexcompute
force-pushed
the
tom/group_delay
branch
from
4dc13d7 to
64ba815
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many users have asked about group delay calculation using FDTD or mode solver. This tutorial addresses this question.