uploading directional scattering notebook #299
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Spell check passed successfully for 2 notebook(s). |
There was a problem hiding this comment.
Great job as always @FilipeFcp ! A couple suggestions:
- (very mild suggestion) maybe specify that you're varying the aspect ratio by varying the radius at the start
- label the axes on the last two plots
Cool visualization on the last plot!
There was a problem hiding this comment.
Thanks @FilipeFcp very interesting model and a great use case of multipole expansion.
- Maybe change the title to "Tailoring directional scattering in silicon nanodisks"?
- "function for carry out multipole decomposition" -> "carrying out"
- "results close match" -> "results closely match"
- Not sure if it's just the github web viewing issue but there is quite a lot of empty space above and below the thumbnail image.
- I didn't check but I assume the metadata have been added properly.
e-g-melo
approved these changes
Jun 4, 2025
There was a problem hiding this comment.
Thanks @FilipeFcp! This is quite an interesting example.
- Starting with cells 4, 5, and 6 under a "Simulation Setup" H2 header would be beneficial. This approach can help users grasp the context before navigating through the dipole expansion functions.
- An H2 header before cell 7, along with an explanation of the purpose of the parameter sweep, would also help users follow the notebook.
- I would recommend moving the comments to the beginning of the cells in markdown format. For example, the comments on cells 7, 8, 9, and 10.
- There are missing labels in the chart of cells 12 and 16.
|
Thank you @alec-flexcompute @e-g-melo and @tomflexcompute for the comments. |
tomflexcompute
approved these changes
Jun 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all,
I’ve reproduced the main steps from this paper. The main idea is that by tuning the magnetic and electric dipole components of the scattering cross section, it’s possible to suppress backscattering reflectance. The paper is a bit confusing in that it performs the mode decomposition for a single sphere, which doesn’t directly apply to an array. This makes the results feel somewhat disconnected. I only noticed this while revising the notebook. Nevertheless, the results match the paper quite well, so it is a good comparison against CST.
I also adapted the multipole expansion notebook to account for a background medium different from air.