Skip to content

uploading directional scattering notebook #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 6, 2025

Conversation

FilipeFcp
Copy link
Contributor

Hi all,
I’ve reproduced the main steps from this paper. The main idea is that by tuning the magnetic and electric dipole components of the scattering cross section, it’s possible to suppress backscattering reflectance. The paper is a bit confusing in that it performs the mode decomposition for a single sphere, which doesn’t directly apply to an array. This makes the results feel somewhat disconnected. I only noticed this while revising the notebook. Nevertheless, the results match the paper quite well, so it is a good comparison against CST.

I also adapted the multipole expansion notebook to account for a background medium different from air.

Copy link
Contributor

github-actions bot commented Jun 4, 2025

Spell check passed successfully for 2 notebook(s).
Generated by GitHub Action run: https://github.com/flexcompute/tidy3d-notebooks/actions/runs/15456261635

Copy link
Contributor

@alec-flexcompute alec-flexcompute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job as always @FilipeFcp ! A couple suggestions:

  1. (very mild suggestion) maybe specify that you're varying the aspect ratio by varying the radius at the start
  1. label the axes on the last two plots

Cool visualization on the last plot!

Copy link
Contributor

@tomflexcompute tomflexcompute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @FilipeFcp very interesting model and a great use case of multipole expansion.

  1. Maybe change the title to "Tailoring directional scattering in silicon nanodisks"?
  2. "function for carry out multipole decomposition" -> "carrying out"
  3. "results close match" -> "results closely match"
  4. Not sure if it's just the github web viewing issue but there is quite a lot of empty space above and below the thumbnail image.
  5. I didn't check but I assume the metadata have been added properly.

Copy link
Contributor

@e-g-melo e-g-melo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @FilipeFcp! This is quite an interesting example.

  1. Starting with cells 4, 5, and 6 under a "Simulation Setup" H2 header would be beneficial. This approach can help users grasp the context before navigating through the dipole expansion functions.
  2. An H2 header before cell 7, along with an explanation of the purpose of the parameter sweep, would also help users follow the notebook.
  3. I would recommend moving the comments to the beginning of the cells in markdown format. For example, the comments on cells 7, 8, 9, and 10.
  4. There are missing labels in the chart of cells 12 and 16.

@FilipeFcp
Copy link
Contributor Author

Thank you @alec-flexcompute @e-g-melo and @tomflexcompute for the comments.
I believe I have addressed all the points.

@tomflexcompute tomflexcompute self-requested a review June 6, 2025 14:55
Copy link
Contributor

@tomflexcompute tomflexcompute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @FilipeFcp . Looks good to go.

@FilipeFcp FilipeFcp merged commit fccc5ca into develop Jun 6, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants