-
Notifications
You must be signed in to change notification settings - Fork 13
uploading directional scattering notebook #299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Spell check passed successfully for 2 notebook(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job as always @FilipeFcp ! A couple suggestions:
- (very mild suggestion) maybe specify that you're varying the aspect ratio by varying the radius at the start
- label the axes on the last two plots
Cool visualization on the last plot!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @FilipeFcp very interesting model and a great use case of multipole expansion.
- Maybe change the title to "Tailoring directional scattering in silicon nanodisks"?
- "function for carry out multipole decomposition" -> "carrying out"
- "results close match" -> "results closely match"
- Not sure if it's just the github web viewing issue but there is quite a lot of empty space above and below the thumbnail image.
- I didn't check but I assume the metadata have been added properly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @FilipeFcp! This is quite an interesting example.
- Starting with cells 4, 5, and 6 under a "Simulation Setup" H2 header would be beneficial. This approach can help users grasp the context before navigating through the dipole expansion functions.
- An H2 header before cell 7, along with an explanation of the purpose of the parameter sweep, would also help users follow the notebook.
- I would recommend moving the comments to the beginning of the cells in markdown format. For example, the comments on cells 7, 8, 9, and 10.
- There are missing labels in the chart of cells 12 and 16.
Thank you @alec-flexcompute @e-g-melo and @tomflexcompute for the comments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @FilipeFcp . Looks good to go.
Hi all,
I’ve reproduced the main steps from this paper. The main idea is that by tuning the magnetic and electric dipole components of the scattering cross section, it’s possible to suppress backscattering reflectance. The paper is a bit confusing in that it performs the mode decomposition for a single sphere, which doesn’t directly apply to an array. This makes the results feel somewhat disconnected. I only noticed this while revising the notebook. Nevertheless, the results match the paper quite well, so it is a good comparison against CST.
I also adapted the multipole expansion notebook to account for a background medium different from air.