-
Notifications
You must be signed in to change notification settings - Fork 13
add dispersion model for comparison and use a few new API improvements #297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
Spell Check ReportCharacteristicImpedanceCalculator.ipynb:
Checked 1 notebook(s). Found spelling errors in 1 file(s). |
a91a61a
to
6eeafe7
Compare
6eeafe7
to
19880a5
Compare
Looks good! Would it be possible to use the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
- "Internally, the ImpedanceCalculator computes impedance using ..." maybe change it to mention that it is one of the 3 approaches
- For Gaussian pulse, how is the result if it's constructed from
from_frequency
? - Could you comment how the 3 methods compared to skrf result?
Basically no change |
Done, I think I found a better way to compare the methods and explain the differences when compared to scikit-rf. I want to still finalize the last cells to show a calculation of a lossy transmission line. |
In that case, better to use |
…the three definitions available in Tidy3d
e43b06c
to
5edf0ce
Compare
Ah, ok! It did change the |
Big change is adding the dispersion model from scikit-rf. I also changed to a 3D PEC for the strip, since our conformal meshing is much improved.
Also added section describing the different definitions of impedance commonly used.