Fix code scanning alerts #27074
Open
Fix code scanning alerts #27074
+7
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasmrod
requested review from
lukeheath,
georgekarrv and
sharon-fdm
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #27074 +/- ##
=======================================
Coverage 63.97% 63.97%
=======================================
Files 1707 1707
Lines 163021 163021
Branches 4384 4384
=======================================
+ Hits 104293 104294 +1
+ Misses 50598 50597 -1
Partials 8130 8130
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sharon-fdm
reviewed
Mar 12, 2025
| @@ -11,6 +11,9 @@ defaults: | |||
| # fail-fast using bash -eo pipefail. See https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#exit-codes-and-error-action-preference | |||
| shell: bash | |||
|
|
|||
| permissions: | |||
| contents: read | |||
There was a problem hiding this comment.
Can you describe this change?
Who is getting read permission?
There was a problem hiding this comment.
This Github action does not modify the repository, so it does not need "write" permissions. Thus we should set that it only needs "read" permissions on the repository (principle of least authority), to prevent abuse in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are fixes to some of the alerts in: https://github.com/fleetdm/fleet/security/code-scanning