Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom SCEP configs #27045

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Add custom SCEP configs #27045

wants to merge 13 commits into from

Conversation

getvictor
Copy link
Member

@getvictor getvictor commented Mar 11, 2025

For #26603

This PR includes:

  • Refactoring of NDES/SCEP verify/timeout logic for easier testing (with dependency injection)
  • Custom SCEP configs
  • saving/deleting/updating of encrypted custom SCEP challenges
  • validation call to custom SCEP server to verify connection
  • Custom SCEP activities
  • unit and integration tests for all of the above

This PR does not include the following:

  • Changes file (in later PR)

Checklist for submitter

  • Added/updated automated tests
  • Manual QA for all new/changed functionality

Copy link

codecov bot commented Mar 11, 2025

Codecov Report

Attention: Patch coverage is 91.74757% with 17 lines in your changes missing coverage. Please review.

Project coverage is 63.89%. Comparing base (de64d1f) to head (f6b4faf).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
server/service/appconfig.go 90.55% 8 Missing and 4 partials ⚠️
cmd/fleet/serve.go 0.00% 2 Missing ⚠️
ee/server/service/scep_proxy.go 96.15% 1 Missing ⚠️
server/datastore/mysql/app_configs.go 95.65% 1 Missing ⚠️
server/datastore/mysql/ca_config_assets.go 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #27045      +/-   ##
==========================================
+ Coverage   63.78%   63.89%   +0.10%     
==========================================
  Files        1726     1712      -14     
  Lines      163926   163654     -272     
  Branches     4366     4301      -65     
==========================================
- Hits       104563   104560       -3     
+ Misses      51216    50944     -272     
- Partials     8147     8150       +3     
Flag Coverage Δ
backend 64.63% <91.74%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@getvictor getvictor marked this pull request as ready for review March 13, 2025 18:19
@getvictor getvictor requested a review from a team as a code owner March 13, 2025 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant