Fix encoding of Uuid's that come from Serde #188
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Uuid are converted to Value::String by default, instead of Value::Uuid
flavray
reviewed
May 7, 2021
| @@ -82,6 +82,9 @@ pub fn encode_ref(value: &Value, schema: &Schema, buffer: &mut Vec<u8>) { | |||
| encode_int(index as i32, buffer); | |||
| } | |||
| } | |||
| Schema::Uuid => { | |||
There was a problem hiding this comment.
nit: you could probably get away with (L77)
Schema::String | Schema::Uuid => {
...
}🙂
|
Can this please be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if there is another way to complete this, I am relatively new to Rust so don't quite understand if we can tame Serde somehow to convert to Value::Uuid.