Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #303

Merged
merged 4 commits into from
Feb 1, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -65,9 +65,9 @@ In this example, we'll construct a time-series of features using the basis objec
import nemos as nmo

# Instantiate the basis
basis_1 = nmo.basis.MSplineBasis(n_basis_funcs=5)
basis_2 = nmo.basis.CyclicBSplineBasis(n_basis_funcs=6)
basis_3 = nmo.basis.MSplineBasis(n_basis_funcs=7)
basis_1 = nmo.basis.MSplineEval(n_basis_funcs=5)
basis_2 = nmo.basis.CyclicBSplineEval(n_basis_funcs=6)
basis_3 = nmo.basis.MSplineEval(n_basis_funcs=7)

basis = basis_1 * basis_2 + basis_3

Expand Down Expand Up @@ -111,7 +111,7 @@ import nemos as nmo

# generate 5 basis functions of 100 time-bins,
# and convolve the counts with the basis.
X = nmo.basis.RaisedCosineBasisLog(5, mode="conv", window_size=100
X = nmo.basis.RaisedCosineLogConv(5, window_size=100
).compute_features(spike_counts)
```
#### Population GLM
Expand Down
2 changes: 1 addition & 1 deletion src/nemos/solvers/_compute_defaults.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@


def glm_compute_optimal_stepsize_configs(
model: Union[GLM, PopulationGLM]
model: Union[GLM, PopulationGLM],
) -> Tuple[Optional[Callable], Optional[Callable], Optional[float]]:
"""
Compute configuration functions for optimal step size selection based on the model.
Expand Down
7 changes: 6 additions & 1 deletion tests/test_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -597,7 +597,12 @@ def __repr__(self):
# Falsey values excluded2
(Example(a=0, b=[], c={}), None, [], "Example(a=0, d=1)"),
# function without the __name__
(nmo.observation_models.PoissonObservations(deepcopy(jax.numpy.exp)),None, [], "PoissonObservations(inverse_link_function=<PjitFunction>)")
(
nmo.observation_models.PoissonObservations(deepcopy(jax.numpy.exp)),
None,
[],
"PoissonObservations(inverse_link_function=<PjitFunction>)",
),
],
)
def test_format_repr(obj, exclude_keys, use_name_keys, expected):
Expand Down