Issue #121: Prevent attribute from being set as property on resource if ... #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…esource if property is not defined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...property is not defined
Per my comments on the issue, I'm not sure whether this behavior is desired or unintentional. The fix was easy though -- I just added a guard in the constructor that only sets
_properties[key]if key is in Factory.properties, with an exception for the_revattribute.A few tests were (ab)using the ability to save arbitrary values so I defined those explicitly to get them working. This illustrates that the new behavior is backwards incompatible and could break for others who are setting and saving arbitrary attributes in this manner.