WIP: [RFC]: Bring Flask-GoogleMaps up to date with latest dependencies #159
Conversation
|
hey @getcake , Making all these changes, it's kind of difficult to maintain backwards compatibility. Along with the aforementioned updates, I am refactoring a bit the code introducing unit tests. Do you have any concerns? Do you think that these changes would be of value? Cheers, |
|
maybe @rochacbruno ? |
argysamo
force-pushed
the
develop
branch
6 times, most recently
from
6e602f4
to
978b301
Compare
|
maybe @cuducos ? |
|
LGTM @argysamo regarding the icon, as long as there is an alternative to add icons with the new markers API I am ok on doing a major release removing the icons API. |
|
The example site build is failing because image is outdated on Netlify, it is running on @Riverfount account, I think what is needed is to check netlify panel and opt-in for an image update I guess. |
I can move it to another account, but which account? |
Sorry guys I can't move the site to another account on Netlify, but I can continue to maintain it in my account! |
|
thanks so much for the feedback and the actions. Great to hear that you are interested in the new Markers API. I will continue with code change and testing, update the documentation and ping you here once the PR is ready to be reviewed! |
|
it's very nice @argysamo . I believe that things as:
Can be separated in another 👏🏾 👏🏾 👏🏾 👏🏾 👏🏾 |
|
Hey @marcuxyz , |
|
needs a rebase |
- Update dependencies (Flask, mypy, python >3.8) - Load javascript in an async manner - Replace obsolete `Marker` with `AdvancedMarkerElement`
- Introduce PinElement - Minor javascript refactoring - Remove icon functionality
- Replace javascript for loops with jinja. I did this in order to create "dynamic" js variables to have an "img" icon. - This is not clever though. I will revert the js loop and then use jinja2 to create the img element when needed
- MarkerContent is an abstract method. It can be either a Pin or Image - Marker object comprises of MarkerContent - Add unit tests - I am bothered by the use of `eval` method for the content
- MarkerContentFactory returns the appropriate MarkerContent implementation (i.e. either Pin or Image) - Add unit tests
- Reformat files with `black` - Update dependencies. E.g. jsmin -> 3.0.1 as this version removes the use_2to3, which creates issues with latest setuptools
- Move and refactor test_map.py - Bump Python dependency to 3.9 - Use latest flake8 revision
|
Hi, guys if you need some help and just me I can do it, mark me on the comment because I see them more quickly. |
- Documentation: Describe the new markers setup - Remove `label` field from marker.py - Add support for `scale` for a pin.py
|
Hello all, Cheers, |
- clusters, moving map, latlon don't work
Fixes #158