Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release the RISC-V binary. #682

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

come-maiz
Copy link
Contributor

Part of #681.

πŸ“ Summary

I've added risc-v to the goreleaser configuration.

β›± Motivation and Context

This will enable the community to alpha test mev-boost in risc-v boards.

πŸ“š References


βœ… I have run these commands

  • make lint
  • make test-race
  • go mod tidy

I build and ran the unit tests in a risc-v qemu.
With cloud-v we are setting up a jenkins project to build and test ethereum clients:
https://dash.cloud-v.co/view/all/job/github_app_come-maiz_165147473562/

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests βœ…

Project coverage is 41.51%. Comparing base (74a8ecb) to head (b56067a).
Report is 21 commits behind head on develop.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #682      +/-   ##
===========================================
- Coverage    43.84%   41.51%   -2.33%     
===========================================
  Files           15       15              
  Lines         1608     1491     -117     
===========================================
- Hits           705      619      -86     
+ Misses         847      828      -19     
+ Partials        56       44      -12     
Flag Coverage Ξ”
unittests 41.51% <ΓΈ> (-2.33%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

Copy link
Collaborator

@jtraglia jtraglia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh exciting. LGTM πŸ‘

Copy link
Collaborator

@metachris metachris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome! curious if it will work in CI, I guess we'll find out

@metachris
Copy link
Collaborator

I guess we could do a test release build on this branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants