server: refactor handleGetHeader #643
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pulls out the verification logic into verifyBid which makes it easier to unit test in the future. It also changes the logic for parallelizing the requests to the builder from using a shared mutex to computing the requests in parallel and assembling the best response after the fact on the main thread
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
This pulls out the verification logic into verifyBid which makes it easier to unit test in the future. It also changes the logic for parallelizing the requests to the builder from using a shared mutex to computing the requests in parallel and assembling the best response after the fact on the main thread
⛱ Motivation and Context
This PR makes verifyBid easier to unit test as it does not depend on setting up multiple relays etc.
This PR also removes some very un-standard logic of using a shared mutex to compute the best bid.
I am not 100% sure about the performance implications of this PR, but I think it should be faster in my opinion, since we do not need to wait for the locking of the mutex