Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: kubernetes playbook request namespace access #164

Merged
merged 10 commits into from
May 30, 2024
Merged

fix: kubernetes playbook request namespace access #164

merged 10 commits into from
May 30, 2024

Conversation

adityathebe
Copy link
Member

resolves: #151

adityathebe
adityathebe commented May 23, 2024
View reviewed changes
charts/kubernetes/templates/playbooks/playbooks.yaml Outdated
label: Commit author
- name: author_email
label: Commit author Email
- name: connection
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should probably add a new parameter type for connection so it's a dropdown
https://docs.flanksource.com/reference/playbooks/parameters#types

@adityathebe adityathebe force-pushed the fix/kubernetes-playbook-request-namespace-access branch from 88b157e to 714c753 Compare May 23, 2024 05:18
@adityathebe
Copy link
Member Author

image

@adityathebe
Copy link
Member Author

localhost_3000_playbooks

@moshloop Do you think we could add a category for parameters as well? So there's a visual grouping for parameters for

  • the repo
  • rolebinding stuff

@adityathebe adityathebe force-pushed the fix/kubernetes-playbook-request-namespace-access branch from b9fa172 to 68281a3 Compare May 23, 2024 12:11
@adityathebe adityathebe force-pushed the fix/kubernetes-playbook-request-namespace-access branch from 1085069 to d5b6b1e Compare May 24, 2024 05:31
@adityathebe adityathebe requested a review from moshloop May 24, 2024 05:34
@adityathebe
Copy link
Member Author

@moshloop https://github.com/flanksource/aws-sandbox/pull/241

@adityathebe adityathebe force-pushed the fix/kubernetes-playbook-request-namespace-access branch from ff011e7 to 26e5f6d Compare May 29, 2024 10:02
@adityathebe adityathebe requested a review from moshloop May 29, 2024 10:12
@adityathebe adityathebe force-pushed the fix/kubernetes-playbook-request-namespace-access branch from 26e5f6d to 205966a Compare May 30, 2024 04:37
@adityathebe adityathebe requested a review from moshloop May 30, 2024 04:37
@moshloop moshloop merged commit 1a9840b into main May 30, 2024
2 checks passed
@moshloop moshloop deleted the fix/kubernetes-playbook-request-namespace-access branch May 30, 2024 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moshloop moshloop Awaiting requested review from moshloop

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Request namespace access playbook not working
2 participants
@adityathebe @moshloop