Skip to content

Add toEncodedQueryParam #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 6, 2022
Merged

Add toEncodedQueryParam #120

merged 2 commits into from
Nov 6, 2022

Conversation

phadej
Copy link
Collaborator

@phadej phadej commented Jul 23, 2022

No description provided.

@fizruk fizruk merged commit 5408b07 into master Nov 6, 2022
@fizruk fizruk deleted the toEncodedQueryParam branch November 6, 2022 09:06
@sandydoo
Copy link

Awesome! Could we get a release? We can then fix query param encoding in servant-client.

georgefst added a commit to georgefst/miso that referenced this pull request Apr 14, 2025
The CPP is necessary, since `toUrlPiece` is incorrect, but we're tied to an old `http-api-data` on GHCJS. See fizruk/http-api-data#120.
dmjio pushed a commit to dmjio/miso that referenced this pull request Apr 14, 2025
* Fix Servant parameter encoding

The CPP is necessary, since `toUrlPiece` is incorrect, but we're tied to an old `http-api-data` on GHCJS. See fizruk/http-api-data#120.

* Make query params optional when specified as such
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants