Replace external tools with fish builtins #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix issue fishgretel#22 Fix issue fishgretel#21 Replace use of external tools (grep and perl) with fish builtin string.
If the 'exit' command was part of the command line, then fish would give a warning and not exit due to how the fasd command was running in the background. Adding a disown after it will stop it from throwing this error. Fix small issue with printf formatting in __fasd_expand_vars
|
The second commit will fix the annoying warning if |
|
Would be nice to merge it. Currently, on macos, if you don't have the gnu coreutils as the default the plugin fails with: The reason is that |
|
Can we proceed with this PR? I find the |
remigourdon
added a commit
to remigourdon/dotfiles
that referenced
this pull request
Apr 11, 2022
This is based from this PR: fishgretel/fasd#23
guerrero
added a commit
to guerrero/dotfiles
that referenced
this pull request
Aug 10, 2022
Latest fishgretel/fasd version introduces a dependency on GNU grep because FreeBSD doesn't support the -P flag. This change replaces fishgretel repo by abysmalbiscuit due it seems fishgretel/fasd has been inactive for a long time Link to the specific PR: fishgretel/fasd#23
for a temporary solution, alias will fix it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the use of external tools (
grepandperl) with fish builtinstringcommand.This should fix both issues #21 and #22.