Explicit fasd in cd function instead of implicit on postexec

[ianhomer]

A cautious PR to address #16.

Cautious because it works for what I need, however it is opinionated in the override of cd. It will also regress behaviour for anyone who was relying on the implicit effect of fish postexec. This change causes the fasd register to only occur when you use cd. I'm raising this PR since it may help find the right direction - happy for any iteration / debate / alternatives.

[gretel]

@ianhomer thanks! i don't worry much about the postexec but about

it is opinionated in the override of cd

think this is too much of a override just calling for confusion.

[ianhomer]

Thx @gretel - agree, that concerns me too for a general release. Fine in someone's dotfiles though.

fasd --init auto shows how it is done in other shells, e.g. bash executes it in the prompt (pretty much like the postexec approach)

_fasd_prompt_func() {
  eval "fasd --proc $(fasd --sanitize $(history 1 | \
    sed "s/^[ ]*[0-9]*[ ]*//"))" >> "/dev/null" 2>&1
}

This generic approach does seem excessive since it fires after each command.

[ianhomer]

Closing pull request - since just not happy with suggesting everyone should override their cd function

[gretel]

@ianhomer hmm ok but what now? :)

[ianhomer]

Good question - this has led me to realise all I need from fasd is remembering the directories I cd into. I think I have lighter need than other fasd users and now I realised that there was this postexec / prompt exec (bash) going on I wanted to strip that out from my systems (since it feels overkill). My use case for fasd is simply the functions / completion below

function cd -d "Register directory and change to directory"
  fasd -A $argv
  builtin cd $argv
end

function z -d "Change directory"
  cd $argv
end

with completions/z.fish

complete -c z -a "(fasd -l -d)" -f

The cd function above is not really compatible with the general scope of the full fasd support that this plugin is trying to achieve. To answer the what next question we'd need to find generic way to do a pre-exec on a command in fish - postexec is too late for wild card removal of files that had been removed. I couldn't find any pre-exec way, so I was stumped - and hence just gone for the simple functions in my dotfiles.