Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GNU grep prerequisite #21

Open
shaharz opened this issue Mar 10, 2021 · 0 comments
Open

GNU grep prerequisite #21

shaharz opened this issue Mar 10, 2021 · 0 comments

Comments

@shaharz
Copy link

shaharz commented Mar 10, 2021

Looks like #20 introduced a dependency on GNU grep (FreeBSD grep doesn't support the -P flag, see e.g. Homebrew/legacy-homebrew#35848). This is easily fixed by installing GNU grep (brew install grep && set -U fish_user_paths /usr/local/opt/grep/libexec/gnubin $fish_user_paths). Another option is switching to perl. Wasn't sure what you prefer so I didn't create a PR.

In any case, thanks for maintaining this!
@shaharz shaharz changed the title GNU grep preqrequisite GNU grep prerequisite Mar 10, 2021
AbysmalBiscuit added a commit to AbysmalBiscuit/fasd that referenced this issue Mar 30, 2021
@AbysmalBiscuit
Replace external tools with fish builtins
25224ce 
Fix issue fishgretel#22
Fix issue fishgretel#21

Replace use of external tools (grep and perl) with fish builtin string.
@AbysmalBiscuit AbysmalBiscuit mentioned this issue Mar 30, 2021
Open
gregorias referenced this issue in gregorias/fasd.fish Apr 30, 2022
@AbysmalBiscuit @gregorias
Replace external tools with fish builtins
3ce5c57 
Fix issue #22
Fix issue #21

Replace use of external tools (grep and perl) with fish builtin string.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@shaharz