Skip to content

fix(#216): FzButton not showing icon when only iconName is set #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

giuliowaitforitdavide
Copy link
Contributor

@giuliowaitforitdavide giuliowaitforitdavide commented Apr 10, 2025

Jira: HD-11175

Closes #216

Copy link
Collaborator

@Crish15 Crish15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pr.
Few things:
1- You should increase the package version inside package.json.
2- You should publish the build of chromatic by running the script “chromatic” inside the file `apps/storybook/package.json

@giuliowaitforitdavide
Copy link
Contributor Author

Thanks for the pr. Few things: 1- You should increase the package version inside package.json. 2- You should publish the build of chromatic by running the script “chromatic” inside the file `apps/storybook/package.json

I also published the build on chromatic @Crish15

@Crish15 Crish15 merged commit f2c7d52 into fiscozen:main Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FzButton not showing icon when only iconName is set
2 participants