On off rework #37
Open
On off rework #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgallen23
requested changes
May 23, 2017
| @@ -29,6 +29,7 @@ | |||
| "devDependencies": { | |||
| "eslint-config-firstandthird": "3.2.0", | |||
| "eslint-plugin-import": "^2.1.0", | |||
| "map-polyfill": "0.0.1", | |||
There was a problem hiding this comment.
So phantom is happy
| @@ -0,0 +1,61 @@ | |||
| const storage = new Map(); | |||
There was a problem hiding this comment.
what does this turn into after running through babel? A little worried that this bloats the code
There was a problem hiding this comment.
Nothing strange, Map is well supported.
There was a problem hiding this comment.
if we have to support anything older than IE 11, this will error, right?
There was a problem hiding this comment.
It will yes, but that'd the least of our problems, lots of things are being used with no support below IE11. Attrobj being the first one which is deep into Domodule. Can use a regular object if you'd still like to strike for IE10 support but this is more performant for the use we are doing.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.