Skip to content

Event revamp #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Event revamp #36

wants to merge 8 commits into from

Conversation

Antonio-Laguna
Copy link
Contributor

This adds a bunch of improvements and bug fixes. I've tested this on all browsers I could, including IE11 just to be extra sure all tests pass on all browsers since events have been heavily changed.

  • Removed phantom dependency to run tests. Want to be able to run tests on browsers to avoid further issues.
  • Added private data cache. Really simple. Intended to be used with Node elements. Probably better to add stuff there instead of using data attributes since we're modifying the DOM. (It is, but is a small amount https://jsperf.com/data-vs-virtual)
  • modify event usage seemed broken, fixed.
  • Added Namespace support. Note that I didn't do nested namespaces since I don't think that's an usecase we're going to have and would mess the code a bit.
  • Fixed the case in which you couldn't unbind when more events of the same type had been already attached.
  • Added the ability to remove a single event handler vs all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant