Separate image reading functions to separate file #1823
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously ReadPicture accessed a global variable "texturedir" meaning that it couldn't be used outside of depending on global variables (meaning it effectively depended on GLUT and GLUI).
Previously, the functions for reading images were in renderimage.c. This commit moves the to readimage.c. While this is a cleaner logical division, a more important difference is that the read image functions can be used without depending on GLUT and GLUI (etc.). As such they can now live in the shared directory and be used by all programs.
|
jake, we are working on getting a new release out. I'll look at this PR after it is out. glenn |
|
No worries Glenn. This is merely groundwork to get rid of some troublesome globals so there's no urgency to it. |
|
I'll provide this in a different PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the functions for reading images were in
renderimage.c. This commit moves the toreadimage.c. This means that the read image functions can be used without depending on GLUT and GLUI etc.As such they can now live in the shared directory and be used by all programs. The code is unchanged with the exception of an additional parameter to replace a global.