Changing to boolean argument in parallel_assert
#11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjward
requested changes
Feb 21, 2025
Co-authored-by: Connor Ward <[email protected]>
Co-authored-by: Connor Ward <[email protected]>
Co-authored-by: Connor Ward <[email protected]>
Co-authored-by: Connor Ward <[email protected]>
…ytest into bool_parallel_assert
connorjward
requested changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the regular Python
assertworks with booleans instead of callables, I was a bit confused why I had to addlambdafor the parallel version now. The only situations where a callable is required as argument inparallel_assertthat @connorjward could come up with are dubious coding practice.So, to streamline the workflow for new users, we decided to switch to boolean argument, while still allowing callables, but raising a warning in that case.
I also added a basic CI pipeline with some unit tests for this. This includes tests that passing callables to
parallel_assertstill works.