Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Releases #10

Merged
merged 7 commits into from
Feb 18, 2025
Merged

Releases #10

merged 7 commits into from
Feb 18, 2025

Conversation

connorjward
Copy link
Collaborator

No description provided.

@connorjward connorjward marked this pull request as draft February 17, 2025 15:50
@connorjward
Copy link
Collaborator Author

@JDBetteridge would love to have your feedback. Also any suggestions for how to test this?

I have decided against poetry because it seems a little excessive purely to patch pyproject.toml.

@JDBetteridge
Copy link
Member

You can tag some commits in this branch (with .dev0 at the end) to test the release workflow. You may also need to push an empty commit to trigger it, I can't remember. Then increment the dev release if/when this fails. I don't think dev versions are installed from PyPI, so you should be safe until you make a "proper" release.

JDBetteridge
JDBetteridge requested changes Feb 17, 2025
View reviewed changes
Copy link
Member

@JDBetteridge JDBetteridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't need the on pr or on branches main

.github/workflows/release.yml Outdated

on:
# TESTING
pull_request:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
pull_request:

@connorjward connorjward marked this pull request as ready for review February 18, 2025 11:14
@connorjward connorjward merged commit ea94159 into main Feb 18, 2025
@connorjward connorjward deleted the connorjward/release branch February 18, 2025 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JDBetteridge JDBetteridge JDBetteridge requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@connorjward @JDBetteridge