Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix quadrature rule hash #132

Merged
merged 5 commits into from
Feb 12, 2025
Merged

Conversation

connorjward
Copy link

@connorjward connorjward commented Jan 31, 2025

Also remove some uses of deprecated @abstractproperty and gives cells and point sets repr()s.

Necessary for firedrakeproject/firedrake#3989

Also remove some uses of deprecated `@abstractproperty` and gives cells
and point sets `repr()`s.
@connorjward
Copy link
Author

@ksagiyam please can you take a look at this too?

Copy link

@ksagiyam ksagiyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR itself looks almost fine to me, but floats being used in some __repr__() could cause issues in computing cache key in firedrake.tsfc_interface.

finat/quadrature.py Outdated Show resolved Hide resolved
@connorjward
Copy link
Author

but floats being used in some repr() could cause issues in computing cache key in firedrake.tsfc_interface.

An excellent catch. I will think on that.

@connorjward
Copy link
Author

This PR itself looks almost fine to me, but floats being used in some repr() could cause issues in computing cache key in firedrake.tsfc_interface.

I have now had a stab at fixing this. UFL provides a format_float function that it uses for this purpose in constantvalue.py.

gem/utils.py Outdated Show resolved Hide resolved
@connorjward connorjward requested a review from ksagiyam February 12, 2025 10:37
@connorjward connorjward merged commit 463c02d into master Feb 12, 2025
8 checks passed
@connorjward connorjward deleted the connorjward/fix-quadrature-hash branch February 12, 2025 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants