-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix quadrature rule hash #132
Conversation
Also remove some uses of deprecated `@abstractproperty` and gives cells and point sets `repr()`s.
@ksagiyam please can you take a look at this too? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR itself looks almost fine to me, but float
s being used in some __repr__()
could cause issues in computing cache key in firedrake.tsfc_interface
.
An excellent catch. I will think on that. |
I have now had a stab at fixing this. UFL provides a |
Also remove some uses of deprecated
@abstractproperty
and gives cells and point setsrepr()
s.Necessary for firedrakeproject/firedrake#3989