Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Removed unusable devctr guide #4148

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

docs: Removed unusable devctr guide #4148

wants to merge 1 commit into from

Conversation

JonathanWoollett-Light
Copy link
Contributor

Changes

Removed out of date guide (devctr-image.md) for updating the dev container image.

Reason

The guide could not be used by non-maintainers.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following
Developer Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

  • If a specific issue led to this PR, this PR closes the issue.
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this PR.
  • API changes follow the Runbook for Firecracker API changes.
  • User-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.
  • New TODOs link to an issue.
  • Commits meet contribution quality standards.
  • This functionality cannot be added in rust-vmm.

@JonathanWoollett-Light JonathanWoollett-Light added Priority: Low Indicates that an issue or pull request should be resolved behind issues or pull requests labelled ` Status: Awaiting review Indicates that a pull request is ready to be reviewed labels Oct 3, 2023
@JonathanWoollett-Light JonathanWoollett-Light self-assigned this Oct 3, 2023
@JonathanWoollett-Light
docs: Removed unusable devctr guide
1c47256 
Removed out of date guide (`devctr-image.md`) for updating the dev
container image as the guide could not be used by non-maintainers.

Signed-off-by: Jonathan Woollett-Light <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmarcalx xmarcalx Awaiting requested review from xmarcalx

@kalyazin kalyazin Awaiting requested review from kalyazin

@pb8o pb8o Awaiting requested review from pb8o

@sudanl0 sudanl0 Awaiting requested review from sudanl0

At least 2 approving reviews are required to merge this pull request.

Assignees

@JonathanWoollett-Light JonathanWoollett-Light

Labels
Priority: Low Indicates that an issue or pull request should be resolved behind issues or pull requests labelled ` Status: Awaiting review Indicates that a pull request is ready to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@JonathanWoollett-Light