Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Vertex AI for Firebase quickstart #1610

Merged
merged 7 commits into from May 13, 2024
Merged

Add Vertex AI for Firebase quickstart #1610

merged 7 commits into from May 13, 2024

Conversation

thatfiredev
Copy link
Member

No description provided.

rlazo pushed a commit to firebase/firebase-android-sdk that referenced this pull request May 9, 2024
This sample app is moving to firebase/quickstart-android:
firebase/quickstart-android#1610
@rlazo
Copy link
Contributor

rlazo commented May 9, 2024

When trying to import the project I get an error about gradle version incompatiblity.

This can be fixed by changing the AGP version to 8.2, or by bumping gradle to 8.6

@thatfiredev
Copy link
Member Author

thatfiredev commented May 9, 2024

@rlazo are you using the latest version of Android Studio (Jellyfish 2023.3.1)? This repo gets its Gradle versions bumped up every time there's a new version of Android Studio.

When I open the project on Android Studio Iguana, I get the following error:

The project is using an incompatible version (AGP 8.4.0) of the Android Gradle plugin. Latest supported version is AGP 8.3.0

Which is expected for now, but I've been considering preventing the bot from updating Gradle immediately and giving it a few months for the new AS version to roll out to developers.

@rlazo
Copy link
Contributor

rlazo commented May 9, 2024

@rlazo are you using the latest version of Android Studio (Jellyfish 2023.3.1)? This repo gets its Gradle versions bumped up every time there's a new version of Android Studio.

When I open the project on Android Studio Iguana, I get the following error:

The project is using an incompatible version (AGP 8.4.0) of the Android Gradle plugin. Latest supported version is AGP 8.3.0

Which is expected for now, but I've been considering preventing the bot from updating Gradle immediately and giving it a few months for the new AS version to roll out to developers.

The gradle version in this PR is 8.4 https://github.com/firebase/quickstart-android/pull/1610/files#diff-e64dc19d8d0422436002e40bac5c0d06b57328d79768a1f4a0f7c3e07beb1ceb

and it's trying to use AGP 8.4 https://github.com/firebase/quickstart-android/pull/1610/files#diff-46902dbaf91bcd2fef57080e7ed01256c976b1f030f29c651c5cc599be9a692b

which requires gradle 8.6 https://developer.android.com/build/releases/gradle-plugin#updating-gradle

@thatfiredev
Copy link
Member Author

@rlazo ah, good catch! Updated.

I wonder why CI didn't complain 🤔

@thatfiredev thatfiredev merged commit 2edbc52 into master May 13, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants