[WIP] Demo always sending token to server #1353
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kroikie
changed the title
marinacoelho
approved these changes
Feb 25, 2022
thatfiredev
reviewed
Feb 25, 2022
| super.onResume() | ||
|
|
||
| // [START send_reg_token] | ||
| FirebaseMessaging.getInstance().token |
There was a problem hiding this comment.
Since this is a Kotlin snippet, we might want to demonstrate KTX here
Suggested change
| FirebaseMessaging.getInstance().token | |
| Firebase.messaging.token |
Comment on lines
+106
to
+108
| val tokenMap: MutableMap<String, String?> = | ||
| HashMap() | ||
| tokenMap["fcm_token"] = token |
There was a problem hiding this comment.
This can be simplified to:
Suggested change
| val tokenMap: MutableMap<String, String?> = | |
| HashMap() | |
| tokenMap["fcm_token"] = token | |
| val tokenMap: MutableMap<String, String?> = hashMapOf("fcm_token" to token) |
| tokenMap["fcm_token"] = token | ||
|
|
||
| // Send token to backend server | ||
| val callable = FirebaseFunctions.getInstance().getHttpsCallable("updateToken") |
There was a problem hiding this comment.
Maybe we can demonstrate KTX here too:
Suggested change
| val callable = FirebaseFunctions.getInstance().getHttpsCallable("updateToken") | |
| val callable = Firebase.functions.getHttpsCallable("updateToken") |
| @@ -8,10 +8,14 @@ import android.util.Log | |||
| import android.widget.Toast | |||
| import androidx.appcompat.app.AppCompatActivity | |||
| import com.google.android.gms.tasks.OnCompleteListener | |||
| import com.google.android.gms.tasks.Task | |||
| import com.google.firebase.functions.FirebaseFunctions | |||
There was a problem hiding this comment.
If the comment above gets applied, we'll need to import functions ktx.
Suggested change
| import com.google.firebase.functions.FirebaseFunctions | |
| import com.google.firebase.functions.FirebaseFunctions | |
| import com.google.firebase.functions.ktx.functions |
piyanut35
approved these changes
Mar 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Developers should regularly send their FCM registration token to their corresponding server. This way the server can determine the freshness or staleness of a particular token and decide whether or not to send messages to that token.
This snippet demonstrates sending the FCM registration token to a callable function that will store it appropriately.