Update dependencies in packages and repo-scripts #8729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsubox76
requested review from
a team,
erikeldridge,
jposuna,
avolkovi,
yoyomyo,
sam-gc,
yuchenshi,
lisajian,
Xiaoshouzi-gh,
pashanka,
mansisampat,
NhienLam,
zwu52,
maneesht,
tonyjhuang and
aashishpatil-g
as code owners
|
hsubox76
force-pushed
the
ch-packages-reposcripts
branch
from
d574275 to
628189c
Compare
hsubox76
force-pushed
the
ch-packages-reposcripts
branch
from
03d26e6 to
b13f1a1
Compare
Size Report 1Affected Products
Test Logs |
Size Analysis Report 1This report is too large (220,029 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.Test Logs |
DellaBitta
approved these changes
Jan 31, 2025
| this.emitFile({ | ||
| fileName: 'package.json', | ||
| source: `{"type":"module"}`, | ||
| type: 'asset' | ||
| }); | ||
| // I'm not sure why, this seems to prevent a rollup race condition? | ||
| console.log('Emitted module package.json file for:', options.file); |
There was a problem hiding this comment.
Probably because console logs are relatively slow compared to everything else..?
There was a problem hiding this comment.
What is the race condition here?
dlarocque
approved these changes
Jan 31, 2025
| this.emitFile({ | ||
| fileName: 'package.json', | ||
| source: `{"type":"module"}`, | ||
| type: 'asset' | ||
| }); | ||
| // I'm not sure why, this seems to prevent a rollup race condition? | ||
| console.log('Emitted module package.json file for:', options.file); |
There was a problem hiding this comment.
What is the race condition here?
Vertex AI Mock Responses Check
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR covers dependency updates in #5566 in the packages/ and repo-scripts/ directories (and some catchup in the main package.json).
Fixes that were needed:
rollup-plugin-typescript2changes affect some packages and require explicitly excluding test files from the rollup build (tests are built with webpack in a separate process)json-stable-stringifyrequired some Firestore tweaksmocha-chai-jest-snapshotinapi-documenterbumps a transitive dependency that has an unlisted dependency onjest-resolve. Addedjest-resolveto get over this but what we really need is an overhaul and update of theapi-documenterfork.