Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create VertexAI Node CJS and ESM bundles #8728

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

dlarocque
Copy link
Contributor

Create a new Node entrypoint index.node.ts where we can make Node-specific modifications to the bundles. This will be required for upcoming features where Node and Web bundles use different libraries.

Question: Should we still be getting the appCheckProvider in a Node bundle?

@dlarocque dlarocque requested a review from hsubox76 January 24, 2025 15:58
@dlarocque dlarocque requested a review from a team as a code owner January 24, 2025 15:58
Copy link

changeset-bot bot commented Jan 24, 2025

🦋 Changeset detected

Latest commit: 7e452ad

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@firebase/vertexai Patch
firebase Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dlarocque dlarocque requested a review from DellaBitta January 24, 2025 15:58
@dlarocque dlarocque requested review from a team as code owners January 24, 2025 16:01
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 24, 2025

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 24, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants