Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Image Generation support using Imagen #8683

Draft
wants to merge 18 commits into
base: main
Choose a base branch
from
Draft

Add Image Generation support using Imagen #8683

wants to merge 18 commits into from

Conversation

dlarocque
Copy link
Contributor

WIP

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 17, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: b8dd77e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

hsubox76
hsubox76 reviewed Dec 17, 2024
View reviewed changes
Copy link
Contributor

@hsubox76 hsubox76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good, just some nits (mostly about doc formatting) and small questions.

common/api-review/vertexai.api.md Show resolved Hide resolved
packages/vertexai/src/api.test.ts Outdated Show resolved Hide resolved
packages/vertexai/src/models/imagen-model.ts Outdated Show resolved Hide resolved
packages/vertexai/src/models/imagen-model.test.ts Outdated Show resolved Hide resolved
packages/vertexai/src/requests/request-helpers.ts Outdated Show resolved Hide resolved
packages/vertexai/src/requests/response-helpers.ts Outdated Show resolved Hide resolved
packages/vertexai/src/types/imagen/requests.ts Outdated Show resolved Hide resolved
@dlarocque dlarocque changed the title WIP Add Image Generation support with Imagen Jan 3, 2025
@dlarocque dlarocque changed the title Add Image Generation support with Imagen Add Image Generation support using Imagen Jan 3, 2025
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 3, 2025 •
edited
Loading

Size Report 1

Affected Products

  • @firebase/firestore

    TypeBase (97d48c7)Merge (582f9e6)Diff
    browser382 kB380 kB-1.86 kB (-0.5%)
    module382 kB380 kB-1.86 kB (-0.5%)
    react-native382 kB380 kB-1.85 kB (-0.5%)

  • @firebase/firestore-lite

    TypeBase (97d48c7)Merge (582f9e6)Diff
    browser112 kB112 kB+47 B (+0.0%)
    module112 kB112 kB+47 B (+0.0%)
    react-native112 kB112 kB+59 B (+0.1%)

  • @firebase/performance

    TypeBase (97d48c7)Merge (582f9e6)Diff
    browser29.1 kB30.6 kB+1.51 kB (+5.2%)
    main29.5 kB31.1 kB+1.56 kB (+5.3%)
    module29.1 kB30.6 kB+1.51 kB (+5.2%)

  • @firebase/vertexai

    TypeBase (97d48c7)Merge (582f9e6)Diff
    browser29.0 kB33.2 kB+4.23 kB (+14.6%)
    main29.9 kB34.2 kB+4.33 kB (+14.5%)
    module29.0 kB33.2 kB+4.23 kB (+14.6%)

  • bundle

    16 size changes

    TypeBase (97d48c7)Merge (582f9e6)Diff
    firestore (CSI Auto Indexing Disable and Delete)273 kB271 kB-1.55 kB (-0.6%)
    firestore (CSI Auto Indexing Enable)273 kB271 kB-1.55 kB (-0.6%)
    firestore (Persistence)304 kB302 kB-1.70 kB (-0.6%)
    firestore (Query Cursors)249 kB249 kB-120 B (-0.0%)
    firestore (Query)247 kB247 kB-120 B (-0.0%)
    firestore (Read data once)235 kB235 kB-135 B (-0.1%)
    firestore (Read Write w Persistence)329 kB327 kB-1.80 kB (-0.5%)
    firestore (Realtime updates)237 kB237 kB-135 B (-0.1%)
    firestore (Transaction)214 kB214 kB-61 B (-0.0%)
    firestore (Write data)214 kB214 kB-88 B (-0.0%)
    firestore-lite (Query Cursors)103 kB103 kB+13 B (+0.0%)
    firestore-lite (Query)99.0 kB99.1 kB+31 B (+0.0%)
    firestore-lite (Read data once)74.5 kB74.5 kB+15 B (+0.0%)
    firestore-lite (Transaction)99.8 kB99.8 kB+32 B (+0.0%)
    firestore-lite (Write data)84.1 kB84.1 kB+9 B (+0.0%)
    performance (trace)51.8 kB62.3 kB+10.5 kB (+20.2%)

  • firebase

    21 size changes

    TypeBase (97d48c7)Merge (582f9e6)Diff
    firebase-analytics.js29.8 kB29.7 kB-22 B (-0.1%)
    firebase-app-check.js24.9 kB24.9 kB-3 B (-0.0%)
    firebase-auth-cordova.js136 kB136 kB-11 B (-0.0%)
    firebase-auth-web-extension.js119 kB119 kB-28 B (-0.0%)
    firebase-auth.js155 kB155 kB-130 B (-0.1%)
    firebase-compat.js800 kB808 kB+8.17 kB (+1.0%)
    firebase-data-connect.js16.8 kB16.8 kB-80 B (-0.5%)
    firebase-database.js187 kB187 kB-59 B (-0.0%)
    firebase-firestore-compat.js347 kB345 kB-1.92 kB (-0.6%)
    firebase-firestore-lite.js130 kB130 kB+55 B (+0.0%)
    firebase-firestore.js441 kB439 kB-1.92 kB (-0.4%)
    firebase-functions.js14.8 kB14.8 kB-36 B (-0.2%)
    firebase-installations.js15.2 kB15.2 kB+8 B (+0.1%)
    firebase-messaging-sw.js30.1 kB30.1 kB-29 B (-0.1%)
    firebase-messaging.js29.1 kB29.1 kB-34 B (-0.1%)
    firebase-performance-compat.js30.8 kB40.9 kB+10.1 kB (+32.7%)
    firebase-performance-standalone-compat.js94.2 kB105 kB+10.5 kB (+11.1%)
    firebase-performance.js35.1 kB45.5 kB+10.4 kB (+29.6%)
    firebase-remote-config.js31.3 kB31.1 kB-134 B (-0.4%)
    firebase-storage.js46.3 kB46.3 kB-32 B (-0.1%)
    firebase-vertexai.js24.0 kB26.8 kB+2.86 kB (+11.9%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/UV8tm8ctLN.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jan 3, 2025 •
edited
Loading

Size Analysis Report 1

This report is too large (561,062 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/KA6JFevIAd.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsubox76 hsubox76 hsubox76 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dlarocque @google-oss-bot @hsubox76