Fix FirebaseServerApp Typescript exactOptionalPropertyTypes error #8341
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussion
This change fixes a TypeScript compilation error.
The
FirebaseServerAppSettings.name
field inherited fromFirebaseAppSettings
but the type was redefined fromstring
toundefined
. This redefinition would cause a TypeScript compliation error ifexactOptionalPropertyTypes
was settrue
inpackages/app/tsconfig.json
.This change now uses
omit< , >
to strip thename
field from theFirebaseServerAppSettings
declaration, whereFirebaseAppSettings
is extended.Fixes #8336
Testing
exactOptionalPropertyTypes
setting defined astrue
.