App Memory And OOM Support #12903
Open
App Memory And OOM Support #12903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added some header docs Added a few simple tests check.sh fixes Moved a few things around
naftaly
commented
May 7, 2024
| FIRCLSAppMemory *memoryInfo = [[FIRCLSAppMemory alloc] initWithJSONObject:breadcrumbs]; | ||
| if (memoryInfo.isOutOfMemory) { | ||
| FIRCLSInfoLog(@"Writing OOM record to %@", path); | ||
| FIRCLSExceptionRecordOutOfMemoryTerminationAtPath(path.UTF8String); |
There was a problem hiding this comment.
I'm surprised that even though the clsrecord is written out correctly, recognized by the local system as a valid part of the report and uploaded to the backend, it is not recognized server side and doesn't end up in the Firecase Crashlytics dashboard. Maybe the maintainers could help me figure out why (I don't think I have access to the backend code).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR introduces
memory pressureandmemory levelsystems in order to effectively track memory terminations and correctly report them changes as non-fatals and report OOMs as well.Why
A lot has changed since this article about handling memory terminations. In order to bring Crashlytics OOM handling up to date, some additional heuristics are needed.
Discussions:
#12897
#12889
#8130