Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable full phone MFA flow for emulator requests #12874

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dantheli
Copy link

Discussion

Fixes #11079 by letting the phone auth provider create a MFA sign in request even if connected to the emulator.

This puts the "send code" logic into a helper method on FIRPhoneAuthProvider that accepts appCredential and reCAPTCHAToken and is called in both emulator and production paths. In the emulator path, these are nil, as the emulator expects.

Testing

Auth tests pass, but I have not written a test for this flow yet.

API Changes

None

Copy link

google-cla bot commented Apr 30, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@dantheli dantheli force-pushed the dantheli/fix-phone-mfa-emulator branch from 95f7a06 to 9640ac0 Compare April 30, 2024 23:34
@paulb777 paulb777 added this to the 10.27.0 - M148 milestone May 1, 2024
@paulb777
Copy link
Member

paulb777 commented May 1, 2024

Thanks for the fix!

Tests would be great. If you'd prefer to write in Swift, feel free to send a PR to the auth-swift branch which will replace the Auth ObjC implementation with a Swift one.

@dantheli
Copy link
Author

dantheli commented May 1, 2024

Oh wow how exciting! When is that planned to be merged? Objc & OCMock have until very recently been a large part of my life for some time so I don't mind, but if the Swift implementation will be merged soon, I'll redo this over on that branch.

@paulb777
Copy link
Member

paulb777 commented May 1, 2024

We're hoping to do in the next few months - but still some open questions about timing.

In the meantime, we should be able to go forward with the ObjC version

@paulb777
Copy link
Member

paulb777 commented May 1, 2024

And would appreciate another PR on the auth-swift branch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MFA_ENROLLMENT_NOT_FOUND on MFA when using Firebase Auth Emulator
2 participants