Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests for exposing internal error description #11322

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Commits on May 19, 2023

  1. Fix error generation when status is .internal

    - when the error received is of type `.internal`, the current code rewrites the message with `descriptionForErrorCode`. This is pretty bad because any contextual information we might have received from Firebase is destroyed.
    - this fix attempts to extract the message from the response payload, preserving the original value.
    - if message is not found, the message is set to the value returned by `descriptionForErrorCode`, as was done before.
    Tito Ciuro committed May 19, 2023
    Configuration menu
    Copy the full SHA
    2aedc9a View commit details
    Browse the repository at this point in the history
  2. Run the style.sh script

    Tito Ciuro committed May 19, 2023
    Configuration menu
    Copy the full SHA
    5fb298f View commit details
    Browse the repository at this point in the history

Commits on May 21, 2023

  1. Update unit tests to reflect the new logic proposal

    Tito Ciuro committed May 21, 2023
    Configuration menu
    Copy the full SHA
    89adc2a View commit details
    Browse the repository at this point in the history

Commits on May 23, 2023

  1. Merge remote-tracking branch 'tc/FixInternalErrorGenerationBug' into …

    …pb-internal-error-fix
    paulb777 committed May 23, 2023
    Configuration menu
    Copy the full SHA
    2f35a9d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f094a90 View commit details
    Browse the repository at this point in the history