Update tests for exposing internal error description

firebase · May 23, 2023 · f094a90 · f094a90
1 parent 2f35a9d
commit f094a90
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 6 deletions.
diff --git a/FirebaseFunctions/Backend/index.js b/FirebaseFunctions/Backend/index.js
@@ -78,7 +78,7 @@ exports.unknownErrorTest = functions.https.onRequest((request, response) => {
  response.status(400).send({
  error: {
  status: 'THIS_IS_NOT_VALID',
- message: 'this should be ignored',
+ message: 'invalid response',
  },
  });
 });

diff --git a/FirebaseFunctions/CHANGELOG.md b/FirebaseFunctions/CHANGELOG.md
@@ -1,3 +1,6 @@
+# 10.11.0
+- [fixed] Provide more detail for internal errors. (#11310)
+
 # 10.10.0
 - [fixed] Fixed potential memory leak of Functions instances. (#11248)
 - [added] Callable functions can now opt in to using limited-use App Check

diff --git a/FirebaseFunctions/Tests/Integration/IntegrationTests.swift b/FirebaseFunctions/Tests/Integration/IntegrationTests.swift
@@ -442,7 +442,7 @@ class IntegrationTests: XCTestCase {
  } catch {
  let error = error as NSError
  XCTAssertEqual(FunctionsErrorCode.internal.rawValue, error.code)
- XCTAssertNotEqual("INTERNAL", error.localizedDescription)
+ XCTAssertEqual("INTERNAL", error.localizedDescription)
  expectation.fulfill()
  return
  }
@@ -473,7 +473,7 @@ class IntegrationTests: XCTestCase {
  } catch {
  let error = error as NSError
  XCTAssertEqual(FunctionsErrorCode.internal.rawValue, error.code)
- XCTAssertNotEqual("INTERNAL", error.localizedDescription)
+ XCTAssertEqual("INTERNAL", error.localizedDescription)
  }
  }
  }
@@ -498,7 +498,7 @@ class IntegrationTests: XCTestCase {
  } catch {
  let error = error as NSError
  XCTAssertEqual(FunctionsErrorCode.internal.rawValue, error.code)
- XCTAssertNotEqual("INTERNAL", error.localizedDescription)
+ XCTAssertEqual("invalid response", error.localizedDescription)
  expectation.fulfill()
  return
  }
@@ -528,7 +528,7 @@ class IntegrationTests: XCTestCase {
  } catch {
  let error = error as NSError
  XCTAssertEqual(FunctionsErrorCode.internal.rawValue, error.code)
- XCTAssertNotEqual("INTERNAL", error.localizedDescription)
+ XCTAssertEqual("invalid response", error.localizedDescription)
  }
  }
  }

diff --git a/FirebaseFunctions/Tests/ObjCIntegration/FIRIntegrationTests.m b/FirebaseFunctions/Tests/ObjCIntegration/FIRIntegrationTests.m
@@ -226,7 +226,7 @@ - (void)testUnknownError {
  completion:^(FIRHTTPSCallableResult *_Nullable result, NSError *_Nullable error) {
  XCTAssertNotNil(error);
  XCTAssertEqual(FIRFunctionsErrorCodeInternal, error.code);
- XCTAssertNotEqualObjects(@"INTERNAL", error.localizedDescription);
+ XCTAssertEqualObjects(@"invalid response", error.localizedDescription);
  [expectation fulfill];
  }];
  [self waitForExpectations:@[ expectation ] timeout:10];