Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Taxonomy Management: ensure previous values are captured on operations like rename / move #6694

Closed
davidwatkins73 opened this issue Aug 4, 2023 · 5 comments
Closed

Taxonomy Management: ensure previous values are captured on operations like rename / move #6694

davidwatkins73 opened this issue Aug 4, 2023 · 5 comments
Assignees
@davidwatkins73
Labels
fixed (test & close) An issue has been fixed, merged into master and is ready for further testing QoL Quality of Life
Milestone
1.56

Comments

@davidwatkins73
Copy link
Member

Description

Currently the changes section just shows things like:

Operation Parameters
Rename New Name
Move New Parent

We want to see the previous name and parent etc.

Resourcing

We intend to contribute this feature
@davidwatkins73 davidwatkins73 added the DDL change Indicates the resolution of this issue will require a DDL change to the Waltz database label Aug 4, 2023
@davidwatkins73 davidwatkins73 added this to the todo : 1.53 milestone Aug 4, 2023
@davidwatkins73
Copy link
Member Author

davidwatkins73 commented Aug 4, 2023 •
edited
Loading

Adding DDL tag speculatively as we probably need somewhere to capture the new values, though they may just go in the parameters field....

@davidwatkins73 davidwatkins73 self-assigned this Nov 19, 2023
@davidwatkins73
Copy link
Member Author

davidwatkins73 commented Nov 19, 2023 •
edited
Loading

Will look to simplify the way the table works. Rather than a dynamic table cell we will pre-process to create a value and originalValue field for each row.

@davidwatkins73
Copy link
Member Author

davidwatkins73 commented Nov 19, 2023 •
edited
Loading

Removing the taxonomy-change-summary-cell widget. No longer needed if pre-computing the values.

Next: ensure the commands are writing something sensible to originalValue parameter.

@davidwatkins73
Copy link
Member Author

image

(1) - New column showing the old value
(2) - The reorder command shows the names of the items being re-ordered, not just their id's

@davidwatkins73 davidwatkins73 added the QoL Quality of Life label Nov 19, 2023
davidwatkins73 added a commit to davidwatkins73/waltz-dev that referenced this issue Nov 19, 2023
@davidwatkins73
Pre compute old/new values for the change table
34d3575 
- decom'd the old `taxonomy-change-summary-cell` component
- updated the new values to cover more command types
- TODO: add the original values to the params object sent to the server

finos#6694
davidwatkins73 added a commit to davidwatkins73/waltz-dev that referenced this issue Nov 19, 2023
@davidwatkins73
Pre compute old/new values for the change table
2a55ccd 
- add the original values to the params object sent to the server
- orig values displayed in table
- reorder siblings commands now records the names rather than just their id's
- bonus: removed console.log in involved-people-section.js

finos#6694
@davidwatkins73 davidwatkins73 added the waiting on contribution Issue has been fixed, however the code has not _yet_ made it's way upstream label Nov 19, 2023
@davidwatkins73 davidwatkins73 removed the DDL change Indicates the resolution of this issue will require a DDL change to the Waltz database label Nov 19, 2023
@davidwatkins73
Copy link
Member Author

Removed ddl label as was not needed.

@davidwatkins73 davidwatkins73 mentioned this issue Nov 19, 2023
Merged
@davidwatkins73 davidwatkins73 added fixed (test & close) An issue has been fixed, merged into master and is ready for further testing and removed waiting on contribution Issue has been fixed, however the code has not _yet_ made it's way upstream labels Nov 21, 2023
@davidwatkins73 davidwatkins73 modified the milestones: done : 1.56, 1.56 Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidwatkins73 davidwatkins73

Labels
fixed (test & close) An issue has been fixed, merged into master and is ready for further testing QoL Quality of Life
Projects
None yet
Milestone
1.56
Development

No branches or pull requests
1 participant
@davidwatkins73