Pre compute old/new values for the change table

- add the original values to the params object sent to the server
- orig values displayed in table
- reorder siblings commands now records the names rather than just their id's
- bonus: removed console.log in involved-people-section.js

finos#6694

waltz-ng/client/involvement/components/involved-people-section.js

@@ -184,7 +184,6 @@ function controller($q, displayNameService, descriptionService, serviceBroker, i
                     .filter(d => d.direction === "EXACT")
                     .value();
                 applyFilters();
-                console.log({raw: vm.rawGridData, curr: vm.currentInvolvements})
             });
     };
 

waltz-ng/client/measurable-category/components/taxonomy-changes/taxonomy-changes-section.js

@@ -59,6 +59,8 @@ function determineValue(change) {
             return `To: ${params.destinationName}`;
         case "MERGE":
             return `Into: ${params.targetName}`;
+        case "REORDER_SIBLINGS":
+            return params.listAsNames;
         default:
             return "-";
     }
@@ -67,7 +69,13 @@ function determineValue(change) {
 
 function determineOriginalValue(change) {
     const params = change.params;
-    return params.originalValue || "-";
+    const orig = params.originalValue || "-";
+    switch (change.changeType) {
+        case "MOVE":
+            return `From: ${orig}`;
+        default:
+            return orig;
+    }
 }
 
 

waltz-ng/client/measurable/components/change-control/measurable-change-control.js

@@ -130,7 +130,8 @@ function controller($scope,
                 },
                 onChange: () => {
                     vm.submitDisabled = vm.commandParams.name === vm.measurable.name;
-                }
+                },
+                paramProcessor: (d) => Object.assign(d, {originalValue: vm.measurable.name})
             }, {
                 name: "Description",
                 code: "UPDATE_DESCRIPTION",
@@ -143,7 +144,8 @@ function controller($scope,
                 },
                 onChange: () => {
                     vm.submitDisabled = vm.commandParams.description === vm.measurable.description;
-                }
+                },
+                paramProcessor: (d) => Object.assign(d, {originalValue: vm.measurable.description})
             }, {
                 name: "Concrete",
                 code: "UPDATE_CONCRETENESS",
@@ -157,7 +159,8 @@ function controller($scope,
                     resetForm({ concrete: !vm.measurable.concrete });
                     vm.submitDisabled = false;
                     calcPreview();
-                }
+                },
+                paramProcessor: (d) => Object.assign(d, {originalValue: vm.measurable.concrete})
             }, {
                 name: "External Id",
                 code: "UPDATE_EXTERNAL_ID",
@@ -171,7 +174,8 @@ function controller($scope,
                 },
                 onChange: () => {
                     vm.submitDisabled = vm.commandParams.externalId === vm.measurable.externalId;
-                }
+                },
+                paramProcessor: (d) => Object.assign(d, {originalValue: vm.measurable.externalId})
             }, {
                 name: "Move",
                 code: "MOVE",
@@ -197,6 +201,7 @@ function controller($scope,
                     resetForm();
                 },
                 paramProcessor: (d) => ({
+                    originalValue: vm.parent.name,
                     destinationId: d.destination.id,
                     destinationName: d.destination.name
                 })
@@ -221,7 +226,9 @@ function controller($scope,
                 },
                 paramProcessor: (commandParams) => {
                     return {
-                        list:  JSON.stringify(_.map(commandParams.list, d => d.id))
+                        originalValue: JSON.stringify(_.map(vm.siblings, d => d.name)),
+                        list: JSON.stringify(_.map(commandParams.list, d => d.id)),
+                        listAsNames: JSON.stringify(_.map(commandParams.list, d => d.name))
                     }
                 }
             }