Merge pull request #172 in WALTZ/waltz from WALTZ/waltz-jws:CTCTOWALT…

…Z-2506-measurable-rating-permissions-fix-6061 to db-feature/waltz-6061-measurable-ratings-permissions-fix

* commit 'ea7c92e3b3c93e6347c322ed81e7ad5ea2a34614':
  Remove second role based premission check on save for measurable ratings

waltz-web/src/main/java/org/finos/waltz/web/endpoints/api/MeasurableRatingEndpoint.java

@@ -147,7 +147,7 @@ private Collection<MeasurableRating> saveRoute(Request request, Response z) thro
                 : Operation.ADD;
 
         checkHasPermissionForThisOperation(command.measurableId(), command.entityReference(), operation, getUsername(request));
-        requireRole(userRoleService, request, measurableRatingService.getRequiredRatingEditRole(mkRef(EntityKind.MEASURABLE, command.measurableId())));
+
         return measurableRatingService.save(command, false);
     }
 
@@ -188,8 +188,10 @@ private void checkHasPermissionForThisOperation(Long measurableId,
                 .user(username)
                 .build();
 
+        boolean involvementBasedPermissions = permissionGroupService.hasPermission(checkPermissionCommand);
+
         checkTrue(
-                roleBasedPermissions || permissionGroupService.hasPermission(checkPermissionCommand),
+                roleBasedPermissions || involvementBasedPermissions,
                 format("User does not have permission to %s measurable ratings for this %s", operation.name().toLowerCase(), parentReference.kind().prettyName()));
     }