Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VUU-333: Add constraints to name, group, and user in BaseMetadata #991

Merged
merged 2 commits into from
Nov 23, 2023

Conversation

cfisher-scottlogic
Copy link
Contributor

Description

SL Ticket
SL PR

As per the ticket, we want the layout server to enforce a constraint that all layout metadata fields are required (except screenshot).

Changelist

This PR makes all fields except screenshot required in BaseMetadata. This applies the constraint to both the controller level request DTO, and the database entity. Tests have been added for the controller level constraint, as this is the behaviour we're concerned with.

Copy link

netlify bot commented Nov 21, 2023

Deploy Preview for papaya-valkyrie-395400 canceled.

Name Link
🔨 Latest commit ce19d37
🔍 Latest deploy log https://app.netlify.com/sites/papaya-valkyrie-395400/deploys/655dccfd92f01900082c13c7

@cfisher-scottlogic cfisher-scottlogic marked this pull request as ready for review November 22, 2023 09:42
@heswell heswell merged commit 3fbc182 into finos:main Nov 23, 2023
9 checks passed
@cfisher-scottlogic cfisher-scottlogic deleted the SLVUU-90-metadata-fields-required branch November 27, 2023 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants