Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create DataSpace editor component #3935

Draft
wants to merge 41 commits into
base: master
Choose a base branch
from

Conversation

travisstebbins
Copy link
Contributor

Summary

Implement DataSpace Editor Component

This PR adds a comprehensive editor component for the DataSpace class, allowing users to visually edit all properties including:

  • Basic properties (title, description)
  • Execution contexts with their properties
  • Default execution context selection
  • Elements with exclude option
  • Executables with title and description
  • Diagrams with title and description
  • Support information (Email or Combined types)

Implementation Details

  • Created a form-based editor in DataSpaceEditor.tsx following the ConnectionEditor pattern
  • Added type-safe action methods in DSL_DataSpace_GraphModifierHelper.ts for updating state
  • Enhanced DataSpaceEditorState.ts with builder methods for creating and checking types
  • Updated the plugin to use the new editor instead of the UnsupportedElementEditorState

Link to Devin run: https://app.devin.ai/sessions/05a5a240789941bb8e6b0158a5709426
Requested by: travis.stebbins@gs.com

How did you test this change?

  • Test(s) added
  • Manual testing (please provide screenshots/recordings)
  • No testing (please provide an explanation)

Sorry, something went wrong.

Copy link

changeset-bot bot commented Mar 12, 2025

⚠️ No Changeset found

Latest commit: b7140eb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

linux-foundation-easycla bot commented Mar 12, 2025

CLA Not Signed

Copy link

codecov bot commented Mar 12, 2025

Codecov Report

Attention: Patch coverage is 2.55720% with 2172 lines in your changes missing coverage. Please review.

Project coverage is 46.62%. Comparing base (b848e3f) to head (b7140eb).

Files with missing lines Patch % Lines
...src/components/DataSpaceExecutionContextEditor.tsx 0.00% 641 Missing ⚠️
...stores/studio/DSL_DataSpace_GraphModifierHelper.ts 0.00% 277 Missing ⚠️
...SpaceGeneralEditor/DataSpaceSupportInfoSection.tsx 0.00% 263 Missing ⚠️
...tudio/src/stores/DataSpaceExecutionContextState.ts 0.00% 134 Missing and 1 partial ⚠️
...on/changeDetection/DSL_DataSpace_ObserverHelper.ts 30.00% 133 Missing ⚠️
...ataSpaceGeneralEditor/DataSpaceDiagramsSection.tsx 0.00% 131 Missing ⚠️
...ataSpaceGeneralEditor/DataSpaceElementsSection.tsx 0.00% 119 Missing ⚠️
packages/legend-art/src/list-editor/ListEditor.tsx 0.00% 112 Missing ⚠️
.../DataSpaceGeneralEditor/DataSpaceGeneralEditor.tsx 0.00% 81 Missing ⚠️
...SpaceGeneralEditor/DataSpaceExecutablesSection.tsx 0.00% 76 Missing ⚠️
... and 8 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3935      +/-   ##
==========================================
- Coverage   46.84%   46.62%   -0.22%     
==========================================
  Files        2291     2300       +9     
  Lines      401482   403645    +2163     
  Branches    17445    11165    -6280     
==========================================
+ Hits       188057   188198     +141     
- Misses     212452   215020    +2568     
+ Partials      973      427     -546     
Files with missing lines Coverage Δ
packages/legend-graph/src/index.ts 0.00% <0.00%> (ø)
packages/legend-art/src/index.ts 0.00% <0.00%> (ø)
...ts/DSL_DataSpace_LegendStudioApplicationPlugin.tsx 0.00% <0.00%> (ø)
...xtension-dsl-data-space/src/graph-manager/index.ts 0.00% <0.00%> (ø)
...ta-space-studio/src/components/DataSpaceEditor.tsx 0.00% <0.00%> (ø)
packages/legend-art/src/layout/Panel.tsx 0.00% <0.00%> (ø)
...Editor/DataSpaceDefaultExecutionContextSection.tsx 0.00% <0.00%> (ø)
...ta-space-studio/src/stores/DataSpaceEditorState.ts 0.00% <0.00%> (ø)
...SpaceGeneralEditor/DataSpaceExecutablesSection.tsx 0.00% <0.00%> (ø)
.../DataSpaceGeneralEditor/DataSpaceGeneralEditor.tsx 0.00% <0.00%> (ø)
... and 8 more

... and 389 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@travisstebbins travisstebbins force-pushed the devin/1741728058-dataspace-editor-component branch 2 times, most recently from 3f3727d to 1684aa2 Compare March 14, 2025 14:44
devin-ai-integration bot and others added 25 commits March 17, 2025 11:00
Co-Authored-By: travis.stebbins@gs.com <travis.stebbins@gs.com>
Co-Authored-By: travis.stebbins@gs.com <travis.stebbins@gs.com>
… and testData inputs and fix default execution context selector bug
…ExecutionContext dropdown updates"

This reverts commit c741775.
Co-Authored-By: travis.stebbins@gs.com <travis.stebbins@gs.com>
Co-Authored-By: travis.stebbins@gs.com <travis.stebbins@gs.com>
@travisstebbins travisstebbins force-pushed the devin/1741728058-dataspace-editor-component branch from 6baa868 to b7140eb Compare March 17, 2025 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant